feat: 동아리 가입 승인 API 추가 #149
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Contributor
There was a problem hiding this comment.
Pull request overview
이 PR은 동아리 가입 신청을 승인하는 API를 추가합니다. 회장과 부회장만 가입 신청을 승인할 수 있으며, 승인 시 신청자는 일반 회원으로 등록되고 회비는 지불된 것으로 처리됩니다.
Changes:
POST /{clubId}/applications/{applicationId}/approve엔드포인트 추가- 회장/부회장 권한 검증을 위한
LEADER_ALLOWED_GROUPS상수 추가 ClubApplyRepository에delete메서드 추가
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| ClubService.java | 가입 신청 승인 로직과 권한 그룹 상수 추가 |
| ClubApplyRepository.java | ClubApply 엔티티 삭제 메서드 추가 |
| ClubApi.java | 가입 승인 API 명세 정의 |
| ClubController.java | 가입 승인 엔드포인트 구현 |
| ClubCreateRequest.java | 예제 문자열 수정 (PR 목적과 무관) |
| ClubUpdateRequest.java | 예제 문자열 수정 (PR 목적과 무관) |
dh2906
force-pushed
the
feat/CAM-190-apply-approve
branch
from
d86f6df to
f90922e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔍 개요
🚀 주요 변경 내용
POST /{clubId}/applications/{applicationId}/approve엔드포인트를 추가했습니다.회장, 부회장의 권한을 가진 유저에 대해서만 가입 신청을 승인할 수 있습니다.
💬 참고 사항
✅ Checklist (완료 조건)